Bug: Incorrect step deleted

Automated deployment for web applications and databases

Moderators: Mike Upton, justin.caldicott, Sean.newham, csmith, chirayu, DavidSimner, david.conlin

Bug: Incorrect step deleted

Postby lee5i3 » Fri Jul 26, 2013 4:51 pm

I have 3 steps in my project.
I choose to delete step 3, it is actually deleting the first step!

And I think I see why...

Each step is in a form
Code: Select all
<form id="delete">


And the "delete" button is doing
Code: Select all
$('#delete').submit();

Looks like JQuery is choosing the first form since they all have the same id
lee5i3
 
Posts: 38
Joined: Fri Jul 16, 2010 9:26 pm

Postby lee5i3 » Fri Jul 26, 2013 5:07 pm

I'm thinking it should be something like
Code: Select all
$(this).parent().submit();
lee5i3
 
Posts: 38
Joined: Fri Jul 16, 2010 9:26 pm

Postby csmith » Mon Jul 29, 2013 2:45 pm

Hi Lee,

Thanks for the post - and your investigation! We are going to look at that asap, and will update this post when we know when the fix will be shipped.

Best regards,
Chris
Chris Smith
Project Manager
Deployment Manager
csmith
 
Posts: 118
Joined: Thu Jun 30, 2011 2:15 pm
Location: Cambridge

Postby DavidSimner » Mon Jul 29, 2013 4:59 pm

Hi Lee,

Sorry!

I've updated our JavaScript to use:

Code: Select all
$(this).parents('form').submit();


Which is slightly different from yours -- it has the advantage that it'll continue working if we ever change the HTML to add a DIV in the DOM between the FORM and the A for example.

Thanks for the bug report -- the fix should ship on Wednesday this week (all being well)...

David
DavidSimner
 
Posts: 49
Joined: Thu Feb 04, 2010 6:05 pm

Postby lee5i3 » Mon Jul 29, 2013 6:56 pm

Sounds good, was more just giving an idea. :)

Figure a bug report with a possible fix would be helpful.
lee5i3
 
Posts: 38
Joined: Fri Jul 16, 2010 9:26 pm


Return to Deployment Manager

Who is online

Users browsing this forum: No registered users and 0 guests